470228 - [A-2] Extension icons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Brian King [:kinger]]

The icons at the bottom left of the Feeds pane were swiped from elsewhere in
Firefox (Windows).

This bug is about:

1) Requesting new images, or making them.

2) Integrating them upon receipt.

These icons should have normal and hover state, size 16x16.

We also need a new icon for the Add-ons Windows listing (32x32)

Comment 1

[Brian King [:kinger]]

Attachment: Current Icons

Here is a screen grab of what the icons look like currently.

1. From left; Add Collection, Reload all collections, Settings.

2. Feeds icon that is also the extension icon.

Comment 2

[Justin Scott [:fligtar]]

I talked with Faaborg a bit about this. The main factor to consider in getting icons is whether we'll be doing platform-specific themes.

I think it's probably OK to try out just using one set of icons on all platforms. Alex said he thinks we have the 3 needed icons in one set available already.

Alex, would you mind attaching them here?

Comment 3

[Justin Scott [:fligtar]]

I've asked Sean Martell to design some icons for us. In the meantime, we can continue using the placeholders.

Comment 4

[Justin Scott [:fligtar]]

Attachment: plus sign

Comment 5

[Justin Scott [:fligtar]]

Attachment: reload

Comment 6

[Justin Scott [:fligtar]]

Attachment: gear

Comment 7

[Justin Scott [:fligtar]]

Attachment: extension icon

Comment 8

[Justin Scott [:fligtar]]

Brian - 3 new button icons attached, to be used on all platforms. Also included the new extension icon.

I still need to get you the platform-specific icons for E-1.8.3

Comment 9

[Brian King [:kinger]]

Thanks, I integrated those. Also consider a minus icon to compliment the plus one. Right now the settings window has both to add/remove a collection. Is this still required in that context?

Comment 10

[Brian King [:kinger]]

Also consider 3 new icons for the panels in Options. For more details see:
https://bugzilla.mozilla.org/attachment.cgi?id=365663

Specs:
- 32x32
- PNG preferred
- 2 states for each, normal and active/hover
- A composite of all 6 would be ideal, but not compulsory

Comment 11

[Justin Scott [:fligtar]]

Attachment: toolbar icon reference

This is a reference to show which toolbar icon goes on which platform

Comment 12

[Justin Scott [:fligtar]]

Attachment: toobar icons

These are the actual toolbar icons

Comment 13

[Justin Scott [:fligtar]]

Okay, the remaining icons needed that I'm aware of are:
- comment icon that indicates when the publisher has commented on an add-on in a collection
- icon for the auto-publisher synced with the current profile
- preferences panel icons for Manage Subscriptions, General Settings, and Auto-publisher Settings

Comment 14

[Justin Scott [:fligtar]]

Brian, for the preferences dialog, is there any reason we couldn't use a few of the placeholder icons permanently? I'm not sure where you got them from, which is why I'm asking, but I think we could use the cog for "General Settings", the Bandwagon logo for "Manage Subscriptions", and I can have an icon made for Auto-publisher Settings. Thoughts?

Comment 15

[Justin Scott [:fligtar]]

If we go with that, I could of course have active/hover states made for the placeholders as well.

Comment 16

[Brian King [:kinger]]

(In reply to comment #14)
> Brian, for the preferences dialog, is there any reason we couldn't use a few of
> the placeholder icons permanently? I'm not sure where you got them from, which
> is why I'm asking, but I think we could use the cog for "General Settings", the
> Bandwagon logo for "Manage Subscriptions", and I can have an icon made for
> Auto-publisher Settings. Thoughts?

The cog is the icon used in the Advanced tab in the Firefox Options window:

radio[pane=paneAuto] {
  list-style-image: url("chrome://browser/skin/preferences/Options.png"); 
  -moz-image-region: rect(0px, 224px, 32px, 192px)
}

Currently we are at the mercy of themes if we leave that rule as is. I suppose we could crop it out from each of the default platform themes and use it per-platform like we do the toolbar button. What do you think?

I forget where the star came from. I just found a larger version from before in the skin/ folder and scaled it for use here. A new icon for Auto-publisher Settings is fine.

Comment 17

[Justin Scott [:fligtar]]

Okay, I've asked Sean for:
1) publisher comments indicator
2) synced auto-publisher icon
3) active/hover state for Bandwagon logo button, and normal + active/hover state for auto-publisher preferences pane

He's not sure when he'll have time to get to those, but in the meantime, let's:
- move Bandwagon icon to Manage Subscriptions
- Move options cog to General Settings, and add active/hover state since that's already available. Let's copy the cog from the options png.
- Move star to auto-publisher prefs so that we can just replace that with the new icon when it's ready

Comment 18

[Brian King [:kinger]]

Attachment: Gear icon composite for all platforms

Comment 19

[Brian King [:kinger]]

FMI, for Gear icons:

0 32 32 0
t   r    b  l
0 64 32 32
32 64 64 32

0 96 32 64
32 96 64 64

0 128 32 96
32 128 64 96

Comment 20

[Brian King [:kinger]]

(In reply to comment #17)
> He's not sure when he'll have time to get to those, but in the meantime, let's:
> - move Bandwagon icon to Manage Subscriptions
> - Move options cog to General Settings, and add active/hover state since that's
> already available. Let's copy the cog from the options png.
> - Move star to auto-publisher prefs so that we can just replace that with the
> new icon when it's ready

Done.

Comment 21

[Justin Scott [:fligtar]]

Attachment: comment icon

Comment icon. OSX, Vista, XP, Tango

Comment 22

[Justin Scott [:fligtar]]

Attachment: auto-publisher designation

icon to designate the auto-publisher associated with the current profile. OSX, Vista, XP, Tango

Comment 23

[Justin Scott [:fligtar]]

Attachment: auto-publisher preferences

Auto-publisher preferences icon. OSX, Vista, XP, Tango

Comment 24

[Justin Scott [:fligtar]]

Attachment: general settings icon

Let's use the same icon Firefox uses for General Settings instead of the gear.

OSX, Vista, XP, Tango

Comment 25

[Justin Scott [:fligtar]]

Attachment: manage subscriptions icon

icon for Manage Subscriptions pane.

first is normal state, second is hover/active in XP, third is hover/active in OS X. Vista and Tango have no hover.

Comment 26

[Justin Scott [:fligtar]]

I think that's all the icons. Is there anything else you need from me, Brian?

Comment 27

[Brian King [:kinger]]

(In reply to comment #26)
> I think that's all the icons. Is there anything else you need from me, Brian?

Can't think of anything right now.

The new prefs icons are in.

Comment 28

[Brian King [:kinger]]

Over to Dave for comment icon and auto-publisher designation icon integration.

Comment 29

[Brian King [:kinger]]

Actually I'll handle the rest.

Comment 30

[Brian King [:kinger]]

Auto-publisher icon in, revision 24263.

Only comment icons to do. I can't see comments in any of the listings however.

Comment 31

[Justin Scott [:fligtar]]

Moving to revised M5 milestone (4/28).

Comment 32

[Brian King [:kinger]]

Comment icons are in, revision 24684. I think that wraps up this bug.